For your tank... I'm assuming you meant which race should you be, not which class, since you seem to want to be a warrior! Well, if you were Horde side I'd recommend Tauren for the health buff. But honestly, I *never* pick a race based on the racial features - only based on the flavor. If you are going Alliance side, I am quite partial to dwarf warriors myself but pick whatever seems most fun to you!
Edit 20 It’s been a week since this post and a lot of people are still reaching out to me with questions which is fine. I have had a few different people reach out to me to help make YouTube videos based off this guide and more info in BFA which I’m more than willing to do. Whoever gets the videos up first I will link them here for you guys to enjoy.