Fishing requires much time and does not yield much profit until its later levels. Unless you enjoy it for its own sake, avoid seriously delving into fishing until your level limit. It is not a bad idea to do a little when starting out a new character on a new server, though - the gray items you fish up sell for good money to a starter, which can help you out with your other tradeskills.
Edit 20 It’s been a week since this post and a lot of people are still reaching out to me with questions which is fine. I have had a few different people reach out to me to help make YouTube videos based off this guide and more info in BFA which I’m more than willing to do. Whoever gets the videos up first I will link them here for you guys to enjoy.